Open
Conversation
Author
|
Test fails appear to be a cargo crate sell value one, as well as something to do with stamina damage on a cleanbot, neither of which I touched in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a text box for entering and copying hex codes for colour selectors.
Why
In my experience this is a fairly standard feature for colour selectors to have. This also makes it less of a hassle to change colours when editing things like markings that allow for multiple colours, since now you can just copy and paste the hex code instead of having to do so for each channel.
Details
Resources/Locale/en-US/controls.ftl
Robust.Client/UserInterface/Controls/ColorSelectorSliders.cs
IsValidis purposely omitted in favour of using the current colour as a fallback, as this triggers as soon as any character in the text box is changed, which prevents you from typing in a code manually if you wanted to do that for whatever reasonOnHexInputValueChangedOnSliderValueChangedUpdateSliderVisualsnow also sets the new text box to the hex representation of the current colourMedia
2026-03-25.20-27-55.mp4
And of course, this doesn't bypass colour restrictions for species like Vox or Vulpkanin:
2026-03-25.20-34-32.mp4
And the field only appears when the HSV/RGB sliders are enabled (IIRC this is only relevant for human skin colour?)